[P2] Silent failures in deploy/disaster/redeploy — ignore_errors everywhere with no assertions #3

New Issue

2026-03-22T18:04:10Z

jeet commented

2026-03-22 18:04:10 +00:00

Problem

Three tasks in a row suppress all errors:

docker compose up -d → ignore_errors: true
30-second pause
Container status check → ignore_errors: true (registers container_status but never asserts on it)

Deployments can silently fail while the playbook reports green. You only find out when a service is unreachable.

Fix

Replace the status check with a real assertion:

- name: Check container status
  ansible.builtin.shell: docker compose ps --services --filter status=running
  args:
    chdir: ~/docker
  register: running_containers
  changed_when: false

- name: Fail if any containers are not running
  ansible.builtin.fail:
    msg: "Some containers failed to start"
  when: running_containers.stdout_lines | length == 0

Files: playbooks/deploy.yml, playbooks/disaster.yml, playbooks/redeploy.yml

## Problem Three tasks in a row suppress all errors: 1. `docker compose up -d` → `ignore_errors: true` 2. 30-second pause 3. Container status check → `ignore_errors: true` (registers `container_status` but never asserts on it) Deployments can silently fail while the playbook reports green. You only find out when a service is unreachable. ## Fix Replace the status check with a real assertion: ```yaml - name: Check container status ansible.builtin.shell: docker compose ps --services --filter status=running args: chdir: ~/docker register: running_containers changed_when: false - name: Fail if any containers are not running ansible.builtin.fail: msg: "Some containers failed to start" when: running_containers.stdout_lines | length == 0 ``` **Files:** `playbooks/deploy.yml`, `playbooks/disaster.yml`, `playbooks/redeploy.yml`

jeet referenced this issue from a commit

2026-03-22 18:14:21 +00:00

Fix issues 3,5,6,7,8,9,11,15,16: security hardening and reliability improvements

jeet closed this issue

2026-03-22 18:14:21 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jeet/OCI_Build#3